Add a sampling method to HIRM. #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #125 |
ThomasColthurst
approved these changes
Aug 13, 2024
| @@ -65,6 +65,11 @@ class HIRM { | |||
|
|
|||
| double logp_score() const; | |||
|
|
|||
There was a problem hiding this comment.
Please add brief descriptions of these methods.
|
|
||
| virtual void incorporate_to_cluster(const T_items& items, const ValueType& value) = 0; | ||
| virtual void incorporate_sample(std::mt19937* prng, const T_items& items) = 0; |
There was a problem hiding this comment.
Please add a description of this new method.
emilyfertig
force-pushed
the
080124-emilyaf-sample-hirm
branch
from
7497f6a
to
b018f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
incorporate_sampletoRelationinstead of taking care of everything in HIRM in anticipation of it being useful for our eventual HIRM/PClean hybrid that will enforce a unique-valued index domain in samples as well.